fix(tui): keep verbose progress from enabling stderr debug logs#31859
Open
xuezhaolan wants to merge 2 commits into
Open
fix(tui): keep verbose progress from enabling stderr debug logs#31859xuezhaolan wants to merge 2 commits into
xuezhaolan wants to merge 2 commits into
Conversation
Collaborator
|
Complements merged #31379 which fixed the CLI side. This PR addresses the remaining TUI-side bug where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display.tool_progress: verbosescoped to structured tool-progress eventsconfig.set verbosefrom togglingAIAgent.verbose_logging, which adds DEBUG logs to stderr and surfaces them as Activitygateway.stderrlinesFixes #31372
Tests
python -m pytest -o addopts='' tests/test_tui_gateway_server.py -k 'verbose or config_set_fast'Note: local full
tests/test_tui_gateway_server.pyrun hit existing environment-dependent browser-launch assertion unrelated to this change; selected regression tests pass.