fix(homeassistant): fall back when states listing fails#31389
Open
XiaoMiku01 wants to merge 1 commit into
Open
fix(homeassistant): fall back when states listing fails#31389XiaoMiku01 wants to merge 1 commit into
XiaoMiku01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Home Assistant entity discovery currently depends on
GET /api/states. Some Home Assistant instances can return HTTP 500 for that endpoint when one integration exposes a state payload that HA cannot serialize for the REST response. When that happens, Hermes cannot list entities at all.This PR keeps the normal
/api/statesbehavior when it works, but falls back to Home Assistant's template API for 5xx responses. The fallback renders compact state records inside HA so Hermes can still discover entities and preserve domain/area filtering. 4xx errors are intentionally re-raised so auth, permission, and configuration problems remain visible.Related Issue
No dedicated issue found. This is related to broader Home Assistant tooling robustness work.
Type of Change
Changes Made
tools/homeassistant_tool.pyaiohttp.ClientResponseErrorfrom/api/states.<500errors so auth/config failures are not masked.>=500errors toPOST /api/template.entity_id,state,friendly_name, andarea._filter_and_summarize()path.tests/tools/test_homeassistant_tool.py/api/templateafter/api/statesfails.How to Test
Verified locally:
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Not applicable. This is a backend tool behavior fix covered by tests.