fix(tui): keep verbose tool progress off stderr#31374
Closed
hclsys wants to merge 1 commit into
Closed
Conversation
Author
|
Closing — superseded by #31379, which already landed the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31372
Summary
display.tool_progress=verboseon structured tool-progress events onlyAIAgent.verbose_logging, which installs a DEBUG stderr handler/verboseconfig changes from enabling Python console logging for existing TUI agentsVerification
python -m pytest -o addopts='' tests/test_tui_gateway_server.py::test_config_set_verbose_keeps_agent_console_logging_off tests/tui_gateway/test_make_agent_provider.py::test_make_agent_keeps_console_logging_off_for_verbose_tool_progress -qgit diff --checkNotes
python -m pytest -o addopts='' tests/test_tui_gateway_server.py tests/tui_gateway/test_make_agent_provider.py -q; unrelated environment failures remain because this local env lacksprompt_toolkit. The targeted regression tests passed.