fix(kanban): stop treating board default_workdir as a scratch workspace#31358
Open
Dusk1e wants to merge 1 commit into
Open
fix(kanban): stop treating board default_workdir as a scratch workspace#31358Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
Contributor
|
Clean fix. The workspace_kind override from 'scratch' to 'dir' when inheriting board default_workdir is the right approach -- the scratch lifecycle (delete on completion) would silently destroy shared repo checkouts otherwise. I hit the same workspace_path/workspace_kind semantics in my WAL leak fix (#31130) -- the kanban workspace lifecycle has a few of these subtle footguns where an inherited default silently triggers the wrong teardown path. The test_complete_task_preserves_inherited_board_default_workdir test with the marker file is a good way to lock it in. |
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Kanban bug where a board
default_workdirwas inherited asworkspace_pathbut still treated asscratch.That made shared board workdirs unsafe:
This change promotes inherited board defaults to
dirworkspaces instead.Files
hermes_cli/kanban_db.pytests/hermes_cli/test_kanban_db.pyValidation
Passed:
python -m pytest tests/hermes_cli/test_kanban_db.py -k default_workdir -q --no-isolate -o addopts="" -p no:timeoutResult:
2 passed, 164 deselected in 0.83s