fix(dashboard): allow explicit proxy hostnames#31304
Closed
joelshu1 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Thanks for pointing this out — I missed the existing dashboard reverse-proxy/allowed-hosts PR cluster. This PR overlaps with #20136 and the related efforts you listed, so I’m closing it to avoid adding another competing implementation. The potentially reusable parts here are the focused host-normalization tests and the Tailscale/reverse-proxy documentation angle. If those would be useful, I can rework them later as a small non-competing follow-up aligned with the canonical Apologies for the duplicate/noise. |
This was referenced May 25, 2026
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:\n- Adds HERMES_DASHBOARD_ALLOWED_HOSTS for explicit dashboard proxy hostnames.\n- Normalizes configured hosts and incoming Host headers before exact matching.\n- Documents reverse-proxy/Tailscale dashboard access and adds host-header tests.\n\nTests:\n- python -m py_compile hermes_cli/web_server.py\n- python -m pytest -o addopts='' tests/hermes_cli/test_web_server_host_header.py