fix(gateway): unify media extension list between extract_media and extract_local_files#31150
Closed
ilonagaja509-glitch wants to merge 1 commit into
Closed
Conversation
…tract_local_files The media_pattern regex in extract_media() had a hardcoded extension list that drifted from the _LOCAL_MEDIA_EXTS tuple in extract_local_files(). Extensions like .html, .md, .json, .svg, .tar, .gz were missing from the MEDIA: directive regex, causing silent data loss when agents emitted explicit MEDIA:/path/file.html tags. Fix by extracting the extension list to a module-level _MEDIA_EXTS constant and using it in both places. The regex is now built dynamically from the same source of truth. Fixes NousResearch#31137
Collaborator
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The media_pattern regex in extract_media() had a hardcoded extension list that drifted from the _LOCAL_MEDIA_EXTS tuple in extract_local_files(). Extensions like .html, .md, .json, .svg, .tar, .gz were missing from the MEDIA: directive regex, causing silent data loss when agents emitted explicit MEDIA:/path/file.html tags.
Fix by extracting the extension list to a module-level _MEDIA_EXTS constant and using it in both places. The regex is now built dynamically from the same source of truth.
Fixes #31137
Checklist