fix: ignore Telegram /start platform pings#31098
Closed
rdasilva1016-ui wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Telegram automatically sends
/startwhen a user opens or launches the bot. Hermes was treating this as a regular command, which could cause an unexpected help dump or interrupt an active agent session mid-run.This fix registers
/startas a known gateway-only command and makes it a silent no-op — no reply, no help, no agent interruption.Changes
hermes_cli/commands.py: registersstartas agateway_onlyCommandDef so it is recognized and dispatchable without appearing in the CLIgateway/run.py: intercepts/starton both the running-agent fast-path and the cold-path, returning an empty string immediatelytests/gateway/test_gateway_command_help.py: assertsstartis inGATEWAY_KNOWN_COMMANDStests/gateway/test_session_race_guard.py: two tests for cold-path and active-session no-op behaviorTest Plan
python -m pytest tests/gateway/test_gateway_command_help.py::test_start_is_known_gateway_command tests/gateway/test_session_race_guard.py::test_start_command_is_noop_and_does_not_show_help tests/gateway/test_session_race_guard.py::test_start_command_is_noop_during_active_session -q -o 'addopts='All 3 pass.