fix(providers): warn on duplicate model provider name/alias registration#30937
Open
WadydX wants to merge 1 commit into
Open
fix(providers): warn on duplicate model provider name/alias registration#30937WadydX wants to merge 1 commit into
WadydX wants to merge 1 commit into
Conversation
- Add warning in register_provider() when a name or alias is being overwritten - Helps surface user plugin overrides vs bundled plugins - Closes NousResearch#30921
Contributor
Author
|
Thanks for the heads-up on overlap with #30984. This PR keeps scope intentionally minimal to address #30921:
If maintainers prefer the test coverage from #30984, I’m happy to fold equivalent tests into this PR or defer to that branch to avoid duplicate review work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30921
Summary
register_provider()now emits a warning when a provider name or alias is being re-registered. This makes user plugin overrides visible instead of silently overwriting bundled profiles.Changes
logger.warning()before overwriting_REGISTRYand_ALIASESTest plan
tests/providers/test_plugin_discovery.pystill passes