fix(kanban): argparse rejects multi-word reasons for unblock (fixes #30897)#30915
Open
mohamedorigami-jpg wants to merge 1 commit into
Open
Conversation
…ousResearch#30897) treated only the first word after the task id as accessible; the rest became unrecognized positional args and argparse rejected the call. Meanwhile accepted multi-word reasons fine. Parser fix: change unblock from bare to the same shape as block — single positional + with + for bulk. Handler fix: join reason with spaces, add an UNBLOCKED comment (matching block's BLOCKED comment), and pass the reason through to the UI output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hermes kanban unblock <id> <reason...>treated only the first word after the task id as the reason. Bare trailing words became extra positional args and argparse rejected the call. The siblinghermes kanban block <id> <reason...>accepted multi-word reasons fine, so the asymmetry was the bug.Fix
Parser (
_build_kanban_parser): changedunblockfrom barenargs="+"to the same shape asblock-- singletask_idpositional +reasonwithnargs="*"+--idsfor bulk unblock with shared reason.Handler (
_cmd_unblock): joins reason with spaces like_cmd_blockdoes, adds an UNBLOCKED comment to the task (matching block's BLOCKED comment), and prints the reason in the output.Testing
tests/hermes_cli/test_kanban_cli.py: 46 passed (no regressions)tests/hermes_cli/test_kanban_db.py: 159 passedhermes kanban unblock t_xxx(no reason, backwards compatible)hermes kanban unblock t_xxx review-complete: all good now(multi-word reason, the fix)hermes kanban unblock t_xxx reason --ids t_yyy(bulk mode)Closes #30897