fix(gateway): match MEDIA tags with case-insensitive file extensions#30722
Closed
Kailigithub wants to merge 1 commit into
Closed
fix(gateway): match MEDIA tags with case-insensitive file extensions#30722Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
Contributor
|
Superseded by #34844, which consolidates this cluster. This PR widens the Closing as superseded — thanks for surfacing and helping pin down this bug; it was part of getting the full fix right. See #34844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
media_patternregex ingateway/platforms/base.pymatchesMEDIA:<path>tags to extractmedia files from agent responses. The regex's file-extension group (
png|jpe?g|gif|...) iscompiled case-sensitively, so files with uppercase extensions like
photo.JPGorimage.PNGnever match. The tag is then silently stripped downstream, producing empty or garbled messages.
Fix
Add
re.IGNORECASEto there.compile()call so that bothphoto.jpgandphoto.JPGarerecognised as valid media paths.
Testing
test_platform_base.pymedia tests pass..JPG,.PNG,.PDF,.OGG,.MP4) now match.Closes #30526