fix(kanban): harden scratch workspace cleanup#30664
Closed
HushUr2Pups8008 wants to merge 1 commit into
Closed
Conversation
Prevent board default workdirs from being treated as disposable scratch workspaces. Add marker-based scratch provenance checks and regression coverage for live project paths, marker mismatches, symlink escapes, and valid scratch cleanup.
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default_workdirvalues from being inherited as disposable scratch workspacesContext
A Kanban board default workdir can point at a durable project checkout. Previously, a task inheriting that default could retain
workspace_kind='scratch', causing cleanup to treat the live project directory as disposable. This hardens both creation-time classification and cleanup-time deletion eligibility.Test Plan
python -m pytest tests/hermes_cli/test_kanban_db.py -q -o 'addopts='