fix(gateway): add re.IGNORECASE to MEDIA tag regex patterns#30535
Closed
ygd58 wants to merge 1 commit into
Closed
Conversation
MEDIA: tags with uppercase file extensions (.JPG, .PNG, .MP4 etc.) were silently dropped — extract_media() only matched lowercase extensions. The raw MEDIA: text was then stripped by downstream cleanup, leaving the user with an empty message (issue NousResearch#30526). Three fixes: 1. base.py extract_media(): add re.IGNORECASE to media_pattern 2. base.py text_content strip: add flags=re.IGNORECASE to re.sub() 3. stream_consumer.py _MEDIA_RE: add re.IGNORECASE companion extract_local_files() already used re.IGNORECASE correctly. Fixes NousResearch#30526
1 task
Contributor
|
Superseded by #34844, which consolidates this cluster. This PR widens the Closing as superseded — thanks for surfacing and helping pin down this bug; it was part of getting the full fix right. See #34844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MEDIA: tags with uppercase extensions (.JPG .PNG .MP4) silently dropped — empty message to user (issue #30526).
Fix
Fixes #30526