fix(gateway): harden restart resume recovery#30030
Open
Qwinty wants to merge 2 commits into
Open
Conversation
387ec85 to
a7fa549
Compare
Contributor
Author
|
Rebased on current Local verification:
CI has been retriggered on |
|
Cherry-picked onto our v0.15.2-based fork (Discord gateway) together with #37669. The two compose cleanly — only a small benign overlap in |
e5069a6 to
a4e81bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resume_pendingmarkerresume_pendingmetadata when Telegram topic binding resolution switches the session entry before the recovery turnRelated Issue
Fixes #10163.
Supersedes the broader #29188 with a narrower restart-resume recovery fix. Related restart-resume and topic-binding work: #23314, #29713.
Tests
/usr/local/lib/hermes-agent/venv/bin/python -m pytest -q -o addopts='' tests/gateway/test_restart_resume_pending.py tests/gateway/test_telegram_topic_mode.py tests/gateway/test_goal_verdict_send.py— 132 passed, 1 warning/usr/local/lib/hermes-agent/venv/bin/python -m py_compile gateway/run.py tests/gateway/test_restart_resume_pending.py tests/gateway/test_telegram_topic_mode.py/usr/local/lib/hermes-agent/venv/bin/python -m ruff check gateway/run.py tests/gateway/test_restart_resume_pending.py tests/gateway/test_telegram_topic_mode.pygit diff --check