Skip to content

Soft-fail slow MCP discovery at startup#29764

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:hermes/fix-29726-mcp-startup-softfail
Open

Soft-fail slow MCP discovery at startup#29764
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:hermes/fix-29726-mcp-startup-softfail

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

Fixes #29726

Summary

  • add an optional startup timeout for MCP discovery and let timed-out discovery continue on the MCP background loop
  • use a short bounded wait during CLI and gateway startup so slow optional MCP servers do not block Hermes boot
  • cover the soft-fail startup path with a targeted MCP discovery test

Testing

  • uv run --frozen pytest -q -o addopts= tests/tools/test_mcp_tool.py -k 'startup_soft_fail or failed_count'\n- uv run --frozen ruff check tools/mcp_tool.py hermes_cli/main.py gateway/run.py tests/tools/test_mcp_tool.py\n- git diff --check

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/gateway Gateway runner, session dispatch, delivery tool/mcp MCP client and OAuth labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists tool/mcp MCP client and OAuth type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP server initialization failure should not prevent Hermes startup

2 participants