Skip to content

fix: require auth for exposed Feishu webhooks#29659

Closed
m0n3r0 wants to merge 2 commits into
NousResearch:mainfrom
m0n3r0:security/feishu-webhook-auth-sanitized
Closed

fix: require auth for exposed Feishu webhooks#29659
m0n3r0 wants to merge 2 commits into
NousResearch:mainfrom
m0n3r0:security/feishu-webhook-auth-sanitized

Conversation

@m0n3r0

@m0n3r0 m0n3r0 commented May 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require a webhook auth secret before starting Feishu/Lark webhook mode on network-accessible bind hosts such as 0.0.0.0
  • validate configured FEISHU_VERIFICATION_TOKEN before responding to url_verification challenges
  • document the fail-closed requirement for exposed Feishu webhooks

Security impact

This hardens the remote Feishu webhook attack surface. Before this change, a publicly exposed webhook listener could be started without FEISHU_VERIFICATION_TOKEN or FEISHU_ENCRYPT_KEY, and URL verification challenges were reflected before token validation. A remote attacker who can reach such a listener could interact with the unauthenticated verification path and, when paired with permissive deployment choices, drive unauthenticated webhook processing.

Test Plan

  • python -m pytest -n 0 tests/gateway/test_feishu.py -q

m0n3r0 added 2 commits May 17, 2026 22:51
Route Mythos/Opus 4.7 aliases through Copilot's Claude Messages mode and validate explicit Copilot model IDs.
@alt-glitch alt-glitch added type/security Security vulnerability or hardening P1 High — major feature broken, no workaround comp/gateway Gateway runner, session dispatch, delivery platform/feishu Feishu / Lark adapter labels May 21, 2026
@m0n3r0 m0n3r0 closed this May 21, 2026
@m0n3r0 m0n3r0 deleted the security/feishu-webhook-auth-sanitized branch May 21, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P1 High — major feature broken, no workaround platform/feishu Feishu / Lark adapter type/security Security vulnerability or hardening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants