fix: require auth for exposed Feishu webhooks#29659
Closed
m0n3r0 wants to merge 2 commits into
Closed
Conversation
Route Mythos/Opus 4.7 aliases through Copilot's Claude Messages mode and validate explicit Copilot model IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.0.0.0FEISHU_VERIFICATION_TOKENbefore responding tourl_verificationchallengesSecurity impact
This hardens the remote Feishu webhook attack surface. Before this change, a publicly exposed webhook listener could be started without
FEISHU_VERIFICATION_TOKENorFEISHU_ENCRYPT_KEY, and URL verification challenges were reflected before token validation. A remote attacker who can reach such a listener could interact with the unauthenticated verification path and, when paired with permissive deployment choices, drive unauthenticated webhook processing.Test Plan
python -m pytest -n 0 tests/gateway/test_feishu.py -q