fix(gateway/slack): enforce allow_from restrictions on block kit interactive callbacks#29627
Open
soynchux wants to merge 1 commit into
Open
fix(gateway/slack): enforce allow_from restrictions on block kit interactive callbacks#29627soynchux wants to merge 1 commit into
soynchux wants to merge 1 commit into
Conversation
…ractive callbacks
19 tasks
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens Slack Block Kit interactive callback authorization for approval and slash-confirm buttons.
Previously, these callback paths only checked
SLACK_ALLOWED_USERS. Deployments using Slack adapter config such asextra.allow_fromfor normal inbound authorization could have approval/slash-confirm button clicks ignore that configured allowlist whenSLACK_ALLOWED_USERSwas unset.This change adds a shared Slack interactive authorization helper that:
SLACK_ALLOWED_USERSprecedence and wildcard supportconfig.extra["allow_from"]when the env allowlist is unsetWhy
Slack button callbacks bypass the normal gateway message authorization flow, so they need to enforce the same configured user allowlist locally. This keeps approval and slash-confirm actions aligned with the adapter’s existing auth configuration.
Tests
Result: passed, exit code
0.git diff --checkalso passed.