fix(telegram): remove duplicate heading and fix multi-row table rendering#29366
Closed
Deserett wants to merge 6 commits into
Closed
fix(telegram): remove duplicate heading and fix multi-row table rendering#29366Deserett wants to merge 6 commits into
Deserett wants to merge 6 commits into
Conversation
When converting markdown tables to Telegram-friendly bullet lists, the first cell was used as the row heading but remained in data_cells, causing duplicate output like: **Вечер (18:00–21:00)** • Время: Вечер (18:00–21:00) ← duplicate • Температура: +17°C Now the first cell is removed from data_cells after being extracted as the heading, eliminating the duplication. Additionally: - Fixed headers slice to happen once before the loop (was inside loop, breaking multi-row tables) - Changed row separator from double newline to single newline for cleaner output Fixes: _render_table_block_for_telegram() in gateway/platforms/telegram.py
Collaborator
|
Supersedes closed #29333 (one-line fix for duplicate heading only). This PR additionally fixes multi-row table rendering ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When converting markdown tables to Telegram-friendly bullet lists, the first cell was used as the row heading but remained in data_cells, causing duplicate output:
Additionally, the
headersslice was inside the loop, breaking multi-row tables (headers became empty on second iteration).Solution
data_cellsafter extracting as heading (eliminates duplicate)headers[1:]slice before the loop (fixes multi-row tables)\n\nto\nwithin groups, keep\n\nbetween groups (cleaner output)Testing
tests/gateway/test_telegram_format.py::TestWrapMarkdownTablespassFiles Changed
gateway/platforms/telegram.py—_render_table_block_for_telegram()functiontests/gateway/test_telegram_format.py— updated assertions to match new behaviorFixes:
_render_table_block_for_telegram()in gateway/platforms/telegram.py