fix(kanban): keep gave_up tasks blocked#29328
Open
LaPelice wants to merge 1 commit into
Open
Conversation
This was referenced May 22, 2026
|
This looks like it addresses another real repro I hit as well. I observed a parented task repeatedly cycling through:
for hundreds of runs before intervention. Notably:
The crash mix included:
So this PR’s approach — keeping From my side, this seems like the right fix direction, and the regression coverage is valuable because it matches observed field behavior beyond just the original repro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gave_upcircuit-breaker blocks sticky inrecompute_ready()until an explicit unblock.gave_up->promoted-> respawn loop seen on Kanban taskt_8a40b49a.Verification
python -m pytest tests/hermes_cli/test_kanban_db.py::test_recompute_ready_keeps_gave_up_circuit_breaker_blocked -q-> failed before fix (promoted == 1).python -m pytest tests/hermes_cli/test_kanban_db.py::test_recompute_ready_keeps_gave_up_circuit_breaker_blocked tests/hermes_cli/test_kanban_db.py::test_recompute_ready_promotes_blocked_with_done_parents -q-> 2 passed.python -m ruff check hermes_cli/kanban_db.py tests/hermes_cli/test_kanban_db.py-> passed.python -m pytest tests/hermes_cli/test_kanban_db.py -q-> 159 passed.Risks
gave_up; dependency-only blocks withoutblocked/gave_upevents still auto-promote.