fix(kanban): clear stale claim locks on ready tasks before dispatch#29214
Open
hettt211 wants to merge 1 commit into
Open
fix(kanban): clear stale claim locks on ready tasks before dispatch#29214hettt211 wants to merge 1 commit into
hettt211 wants to merge 1 commit into
Conversation
Stale claim_lock/claim_expires/worker_pid fields can leak onto ready tasks when a worker crashes and the task is later manually unblocked (e.g. from 'blocked' back to 'ready' via SQL). The reclaim path only inspects status='running' tasks, so these stale locks are never released and the task is permanently skipped by dispatch. Fix: clear claim_lock/claim_expires/worker_pid on any ready task before the dispatch spawn loop. A task in status='ready' cannot have a live worker by definition, so these fields are always stale. Fixes NousResearch#22926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clear stale claim_lock/claim_expires/worker_pid fields on ready tasks
at the start of each dispatch tick. A task in
readystatus cannot havea live worker — these fields are always stale residue from a previous
crashed or blocked run.
release_stale_claimsonly inspectsrunningtasks, so stale locks were permanently blocking dispatch.
Related Issue
Fixes #22926
Type of Change
Changes Made
dispatch spawn loop —
UPDATE tasks SET claim_lock=NULL, claim_expires=NULL, worker_pid=NULL WHERE status='ready' AND claim_lock IS NOT NULLHow to Test
an invalid API key)
Checklist
pytest tests/ -qand all tests passDocumentation & Housekeeping