refactor: remove /model slash command from CLI and gateway#2909
Closed
teknium1 wants to merge 1 commit into
Closed
refactor: remove /model slash command from CLI and gateway#2909teknium1 wants to merge 1 commit into
teknium1 wants to merge 1 commit into
Conversation
The /model command is removed from both the interactive CLI and messenger gateway (Telegram/Discord/Slack/WhatsApp). Users can still change models via 'hermes model' CLI subcommand or by editing config.yaml directly. Removed: - CommandDef entry from COMMAND_REGISTRY - CLI process_command() handler and model autocomplete logic - Gateway _handle_model_command() and dispatch - SlashCommandCompleter model_completer_provider parameter - Two-stage Tab completion and ghost text for /model - Tab re-trigger for provider:model completion - All /model-specific tests Updated: - _show_model_and_providers() hints now point to 'hermes model' - /provider command unaffected (still works) - ACP adapter _cmd_model unaffected (separate system) - model_switch.py module preserved (used by ACP)
Contributor
Author
|
Merged via PR #3080. Cherry-picked onto current main with conflict resolution (2 conflicts from 42-commit drift, both in the code being removed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
/modelslash command from the interactive CLI and all messenger gateway platforms (Telegram, Discord, Slack, WhatsApp).Users can still change models via
hermes modelCLI subcommand or by editingconfig.yamldirectly.Changes
Removed:
CommandDefentry fromCOMMAND_REGISTRYincommands.pyprocess_command()handler (~85 lines)_handle_model_command()method (~190 lines)SlashCommandCompletermodel_completer_provider parameter and two-stage autocomplete logic/model provider:completion/model/model-specific tests (test_cli_model_command.py+ model completion tests intest_commands.py)Updated:
_show_model_and_providers()hints now point tohermes modelinstead of/modelUnaffected:
/providercommand (still works, still calls_show_model_and_providers)_cmd_model(separate system for VS Code/Zed/JetBrains)hermes_cli/model_switch.pymodule preserved (used by ACP)hermes modelCLI subcommand (unchanged)Test plan
/providerstill works (shares_show_model_and_providers)/modelcommand remain in active code