fix(windows): remove duplicate creationflags in local subprocess Popen call#29028
Open
momowind wants to merge 1 commit into
Open
fix(windows): remove duplicate creationflags in local subprocess Popen call#29028momowind wants to merge 1 commit into
momowind wants to merge 1 commit into
Conversation
The _popen_kwargs dict already provides creationflags via windows_hide_flags() (CREATE_NO_WINDOW). The explicit creationflags=subprocess.CREATE_NO_WINDOW on the Popen call created a duplicate keyword argument on Windows, causing: TypeError: subprocess.Popen() got multiple values for keyword argument 'creationflags' Remove the redundant explicit parameter; _popen_kwargs handles it via the already-established compat-layer pattern.
Collaborator
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, every terminal tool call fails with:
Root Cause
In
tools/environments/local.py, the_run_bashmethod passescreationflagstosubprocess.Popen()twice on Windows:_popen_kwargsdict (windows_hide_flags()→CREATE_NO_WINDOW)creationflags=subprocess.CREATE_NO_WINDOWparameterPython raises
TypeErrorwhen the same keyword argument appears twice (once directly, once via**dictexpansion).Fix
Remove the redundant explicit
creationflagsparameter._popen_kwargsalready handles it via the establishedwindows_hide_flags()compat-layer helper.Commit
2b454a0f1— single-line deletion, 1 file changed, 1 deletion.