fix: add html to extract_media extension list for native file delivery#28973
Closed
sebastiannicolas-analytia wants to merge 1 commit into
Closed
Conversation
The extract_media regex in BasePlatformAdapter detects MEDIA:<path> tags in agent responses to deliver files as native platform attachments. The extension list in the bare-path alternative was missing 'html', so paths like MEDIA:/path/to/file.html were not captured for native delivery. Add 'html|' to the extension alternation so the regex matches .html files alongside the existing image/video/audio/document extensions.
Collaborator
Author
13 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix to add
htmlto the extension list inBasePlatformAdapter.extract_media()regex.Problem
The
extract_mediastatic method detectsMEDIA:<path>tags in agent responses and extracts file paths for native platform delivery. The bare-path alternative in the regex matches files by extension, buthtmlwas missing from the alternation list.This meant that when an agent generated artifacts like
MEDIA:/path/to/dashboard.html, the file was never detected for native delivery.Fix
Add
html|at the start of the extension alternation ingateway/platforms/base.py:2162:Verification
Tested with the Python
remodule — the fixed regex now correctly matches paths likeMEDIA:/path/to/file.htmlat end-of-string.