test: update pytest-isolate PR onto current main#28966
Closed
AJV20 wants to merge 2 commits into
Closed
Conversation
Each test now runs in a forked subprocess (--isolate), so module-level dicts/sets/ContextVars can no longer leak between tests on the same xdist worker. This eliminates the need for: - _reset_module_state autouse fixture (~120 lines clearing approval state, gateway session ContextVars, terminal env caches, etc.) - _enforce_test_timeout + _timeout_handler (SIGALRM-based 30s timeout) - _reset_tool_registry_caches (registry + tool defs cache invalidation) With isolation in place, bump the xdist worker cap from 4 to auto in scripts/run_tests.sh and pyproject.toml addopts. Developers on big machines finally get parallelism proportional to their core count.
19 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/main.hermes_cli/setup.pyno longer appears ingit diff origin/main..HEAD.pytest-isolateexact-pinned as==0.0.13, so the dependency-bounds check no longer sees an unbounded>=spec.Supersedes/repairs #28956.
Verification
git diff --name-only origin/main..HEAD | grep -E '(^|/)(setup\.py|setup\.cfg|sitecustomize\.py|usercustomize\.py|__init__\.pth)$'→ no output.github/workflows/supply-chain-audit.yml→ no output/Users/abdiel/.hermes/hermes-agent/venv/bin/python -m py_compile tests/conftest.pyuv run --extra dev python -m pytest tests/hermes_cli/test_setup_matrix_e2ee.py -q→1 passed