fix(model-switch): mark bare custom provider as current#28860
Merged
Conversation
Contributor
🔎 Lint report:
|
13 tasks
19 tasks
This was referenced May 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #23559 by @LeonSGP43 onto current main.
Summary
Fixes
hermes modelpicker listing the wrong custom provider as current when the active provider slug is the barecustombucket. The picker now also matches by current base_url, so the correct custom endpoint is markedis_current.Fixes #20811.
Changes
hermes_cli/model_switch.py:is_currentfalls back to comparingcurrent_base_urlagainst the group's normalized URL when the slug match fails (_grp_url_normis already computed in the same function).tests/hermes_cli/test_model_switch_custom_providers.py: tightened the existing bare-custom regression test to also assertis_current is True.Validation
tests/hermes_cli/test_model_switch_custom_providers.py: 18/18 passing.Original PR #23559 cherry-picked cleanly (981 commits stale, no conflicts). LeonSGP43's authorship preserved.