fix(agent): add recovery hints to tool loop warnings (#28256)#28592
Merged
Conversation
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #28256 by @ooovenenoso.
What: When the same tool fails repeatedly within a turn, the guardrail emitted only
'{tool} has failed N times this turn. This looks like a loop; change approach before retrying.'. Some models took this as a signal to STOP using tools entirely and pivot to a text-only reply, which is the opposite of what we want — the agent should keep using tools but diagnose first.How: Replace the warning with an action-oriented hint via
_tool_failure_recovery_hint(). Common preamble keeps the loop-detection signal but explicitly tells the model to keep using tools and run a diagnostic first. Tool-specific branch forterminalsuggestspwd && ls -la+ absolute paths / different tools (read_file/write_file/patch); generic branch covers everything else. Tests added.Original PR: #28256
Fixes #28204.