fix(gateway): tolerate unreadable JSONL transcripts (#28288)#28590
Merged
Conversation
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #28288 by @MoonJuhan. (Note: the original PR was closed earlier per user request; reopening the fix here because the gateway crash on unreadable JSONL is still real and the SQLite fallback path is sound.)
What: Gateway sessions persist in both SQLite AND legacy JSONL files.
load_transcript()reads BOTH and picks whichever has more messages. The JSONL read is guarded for per-lineJSONDecodeError(corrupt line → skip), but theopen()call itself is unguarded — so disk error / permission flap / NFS hiccup raisesOSErrorand session recovery crashes even though SQLite has the full transcript.How: Wrap the JSONL
open()intry/except OSError. On failure, log at debug and fall through to the SQLite messages. New test monkeypatchesopento raise OSError and asserts SQLite history is returned instead.Original PR: #28288