Skip to content

fix(telegram): handle channel post updates#28531

Merged
teknium1 merged 3 commits into
mainfrom
hermes/hermes-6063e704
May 19, 2026
Merged

fix(telegram): handle channel post updates#28531
teknium1 merged 3 commits into
mainfrom
hermes/hermes-6063e704

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvage of #25327 (@brndnsvr). Routes Telegram handlers through effective_message so channel_post updates build gateway events instead of being silently ignored. Preserves channel identity for channel posts without from_user so operators can allowlist by chat id.

Conflict resolution: combined with #28503 (#27014 forum-commands) — both add new methods on TelegramAdapter; kept both.

Authorship preserved across 2 commits via cherry-pick. 3/3 channel-post tests passing. Follow-up commit stubs auth in the test fixture (channel posts have from_user=None and were getting rejected by #28494's fail-closed gate).

@teknium1 teknium1 merged commit f1cefad into main May 19, 2026
@teknium1 teknium1 deleted the hermes/hermes-6063e704 branch May 19, 2026 05:51
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-6063e704 vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8950 on HEAD, 8933 on base (🆕 +17)

🆕 New issues (20):

Rule Count
unresolved-attribute 19
unresolved-import 1
First entries
tests/gateway/test_telegram_channel_posts.py:33: [unresolved-attribute] unresolved-attribute: Unresolved attribute `CommandHandler` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:32: [unresolved-attribute] unresolved-attribute: Unresolved attribute `Application` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:177: [unresolved-attribute] unresolved-attribute: Attribute `args` is not defined on `None` in union `_Call | None`
tests/gateway/test_telegram_channel_posts.py:36: [unresolved-attribute] unresolved-attribute: Unresolved attribute `ContextTypes` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:49: [unresolved-attribute] unresolved-attribute: Unresolved attribute `HTTPXRequest` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:26: [unresolved-attribute] unresolved-attribute: Unresolved attribute `Message` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:16: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`
tests/gateway/test_telegram_channel_posts.py:35: [unresolved-attribute] unresolved-attribute: Unresolved attribute `MessageHandler` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:29: [unresolved-attribute] unresolved-attribute: Unresolved attribute `LinkPreviewOptions` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:41: [unresolved-attribute] unresolved-attribute: Unresolved attribute `ChatType` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:52: [unresolved-attribute] unresolved-attribute: Unresolved attribute `constants` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:27: [unresolved-attribute] unresolved-attribute: Unresolved attribute `InlineKeyboardButton` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:37: [unresolved-attribute] unresolved-attribute: Unresolved attribute `filters` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:24: [unresolved-attribute] unresolved-attribute: Unresolved attribute `Update` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:28: [unresolved-attribute] unresolved-attribute: Unresolved attribute `InlineKeyboardMarkup` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:25: [unresolved-attribute] unresolved-attribute: Unresolved attribute `Bot` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:53: [unresolved-attribute] unresolved-attribute: Unresolved attribute `request` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:34: [unresolved-attribute] unresolved-attribute: Unresolved attribute `CallbackQueryHandler` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:51: [unresolved-attribute] unresolved-attribute: Unresolved attribute `ext` on type `ModuleType`
tests/gateway/test_telegram_channel_posts.py:40: [unresolved-attribute] unresolved-attribute: Unresolved attribute `ParseMode` on type `ModuleType`

✅ Fixed issues: none

Unchanged: 4680 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/bug Something isn't working platform/telegram Telegram bot adapter comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists labels May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/telegram Telegram bot adapter type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants