feat(kanban): configure worktree paths and branches (#26496)#28462
Merged
Conversation
Salvages #26496 by @aqilaziz. Adds branch_name column + CLI flag so tasks with workspace_kind='worktree' can pin a target branch on create. Schema migration added to _migrate_add_optional_columns. - Task.branch_name field + DB column + migration - create_task accepts branch_name kwarg - hermes kanban create --branch <name> flag - kanban show output includes 'Branch: <name>' when set Cherry-picked the substantive commit (a7558cf); the PR's tip was an unrelated service-path-dirs commit. Resolved 2 INSERT-column-list and show-output conflicts alongside main's session_id and max_runtime_seconds additions; kept all three.
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
not-subscriptable |
1 |
unresolved-attribute |
1 |
First entries
tests/hermes_cli/test_kanban_db.py:99: [not-subscriptable] not-subscriptable: Cannot subscript object of type `None` with no `__getitem__` method
tests/hermes_cli/test_kanban_db.py:98: [unresolved-attribute] unresolved-attribute: Attribute `branch_name` is not defined on `None` in union `Task | None`
✅ Fixed issues: none
Unchanged: 4642 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #26496 by @aqilaziz.
Adds
branch_namecolumn + CLI flag so tasks withworkspace_kind='worktree'can pin a target branch on create. Schema migration is additive (additive ALTER TABLE in_migrate_add_optional_columns).Task.branch_namefield + DB column + migrationcreate_task()acceptsbranch_namekwarghermes kanban create --branch <name>flagkanban showoutput includesBranch:line when setCherry-picked the substantive commit (
a7558cf27); the PR's tip was an unrelated service-path-dirs commit. Resolved 2 conflicts inkanban_db.py(INSERT column list + show output) alongside main'ssession_idandmax_runtime_secondsadditions — kept all three. Dropped an unrelated test_provider_parity formatting tweak. Authorship preserved via rebase merge.Validation