feat(kanban): show dashboard cron jobs across profiles + fix config.py markers (#27568)#28457
Merged
Conversation
Salvages #27568 by @SerenityTn. Dashboard cron page now lists cron jobs from all profiles, with profile-aware filter UI and storage routing. Includes test coverage for cross-profile listing, mutation, deletion, and validation. Also fixes orphan conflict markers in config.py left by an earlier salvage merge (kanban.dispatch_stale_timeout_seconds was double-nested in HEAD/PR markers from #28452 salvage of #23790).
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-syntax |
30 |
First entries
hermes_cli/config.py:1533: [invalid-syntax] Expected `,`, found `<<`
hermes_cli/kanban.py:370: [invalid-syntax] Expected `,`, found string
hermes_cli/config.py:1565: [invalid-syntax] Unparenthesized generator expression cannot be used here
hermes_cli/kanban.py:77: [invalid-syntax] Expected `:`, found `,`
hermes_cli/kanban.py:378: [invalid-syntax] Duplicate keyword argument "help"
hermes_cli/kanban.py:1346: [invalid-syntax] Expected `,`, found `:`
hermes_cli/kanban.py:1346: [invalid-syntax] Expected `,`, found `>>`
hermes_cli/config.py:1537: [invalid-syntax] Expected `:`, found `,`
hermes_cli/config.py:1565: [invalid-syntax] Expected `in`, found name
hermes_cli/kanban.py:77: [invalid-syntax] Expected `:`, found string
hermes_cli/config.py:1565: [invalid-syntax] Expected `,`, found `:`
hermes_cli/kanban.py:1341: [invalid-syntax] Expected `,`, found `<`
hermes_cli/config.py:1565: [invalid-syntax] Expected `,`, found `>>`
hermes_cli/kanban.py:1346: [invalid-syntax] Expected `,`, found name
hermes_cli/config.py:1537: [invalid-syntax] Expected `:`, found string
hermes_cli/config.py:1565: [invalid-syntax] Expected `,`, found name
hermes_cli/kanban.py:369: [invalid-syntax] Expected an expression or a ')'
hermes_cli/kanban.py:1343: [invalid-syntax] Expected `,`, found `=`
hermes_cli/config.py:1533: [invalid-syntax] Expected `,`, found `<`
hermes_cli/config.py:1558: [invalid-syntax] Expected `,`, found `=`
hermes_cli/kanban.py:1343: [invalid-syntax] Expected `,`, found `==`
hermes_cli/kanban.py:1346: [invalid-syntax] Positional argument cannot follow keyword argument
hermes_cli/config.py:1558: [invalid-syntax] Expected `,`, found `==`
hermes_cli/kanban.py:1346: [invalid-syntax] Expected `,`, found `>`
hermes_cli/kanban.py:376: [invalid-syntax] Duplicate keyword argument "default"
... and 5 more
✅ Fixed issues (30):
| Rule | Count |
|---|---|
invalid-syntax |
30 |
First entries
../../../../../tmp/lint-base/hermes_cli/kanban.py:1346: [invalid-syntax] Expected `,`, found `:`
../../../../../tmp/lint-base/hermes_cli/kanban.py:1346: [invalid-syntax] Expected `,`, found `>>`
../../../../../tmp/lint-base/hermes_cli/kanban.py:77: [invalid-syntax] Expected `:`, found string
../../../../../tmp/lint-base/hermes_cli/kanban.py:1346: [invalid-syntax] Expected `,`, found name
../../../../../tmp/lint-base/hermes_cli/config.py:1565: [invalid-syntax] Expected `:`, found name
../../../../../tmp/lint-base/hermes_cli/kanban.py:1341: [invalid-syntax] Expected `,`, found `<`
../../../../../tmp/lint-base/hermes_cli/config.py:1565: [invalid-syntax] ParseIntError { kind: Empty }
../../../../../tmp/lint-base/hermes_cli/config.py:1533: [invalid-syntax] Expected `,`, found `<<`
../../../../../tmp/lint-base/hermes_cli/kanban.py:1343: [invalid-syntax] Expected `,`, found `=`
../../../../../tmp/lint-base/hermes_cli/kanban.py:369: [invalid-syntax] Expected an expression or a ')'
../../../../../tmp/lint-base/hermes_cli/config.py:1565: [invalid-syntax] Unparenthesized generator expression cannot be used here
../../../../../tmp/lint-base/hermes_cli/kanban.py:1343: [invalid-syntax] Expected `,`, found `==`
../../../../../tmp/lint-base/hermes_cli/kanban.py:1346: [invalid-syntax] Positional argument cannot follow keyword argument
../../../../../tmp/lint-base/hermes_cli/config.py:1537: [invalid-syntax] Expected `:`, found `,`
../../../../../tmp/lint-base/hermes_cli/kanban.py:376: [invalid-syntax] Duplicate keyword argument "default"
../../../../../tmp/lint-base/hermes_cli/kanban.py:1346: [invalid-syntax] Expected `,`, found `>`
../../../../../tmp/lint-base/hermes_cli/config.py:1565: [invalid-syntax] Expected `in`, found name
../../../../../tmp/lint-base/hermes_cli/config.py:1565: [invalid-syntax] Expected `,`, found `:`
../../../../../tmp/lint-base/hermes_cli/config.py:1565: [invalid-syntax] Expected `,`, found `>>`
../../../../../tmp/lint-base/hermes_cli/config.py:1537: [invalid-syntax] Expected `:`, found string
../../../../../tmp/lint-base/hermes_cli/kanban.py:81: [invalid-syntax] Expected `:`, found name
../../../../../tmp/lint-base/hermes_cli/config.py:1565: [invalid-syntax] Expected `,`, found name
../../../../../tmp/lint-base/hermes_cli/config.py:1533: [invalid-syntax] Expected `,`, found `<`
../../../../../tmp/lint-base/hermes_cli/kanban.py:1341: [invalid-syntax] Expected `,`, found `<<`
../../../../../tmp/lint-base/hermes_cli/config.py:1558: [invalid-syntax] Expected `,`, found `=`
... and 5 more
Unchanged: 0 pre-existing issues carried over.
ty (type checker)
Total: 9002 on HEAD, 9000 on base (🆕 +2)
🆕 New issues (2):
| Rule | Count |
|---|---|
unresolved-import |
2 |
First entries
tests/hermes_cli/test_web_server_cron_profiles.py:4: [unresolved-import] unresolved-import: Cannot resolve imported module `fastapi`
tests/hermes_cli/test_web_server_cron_profiles.py:3: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`
✅ Fixed issues: none
Unchanged: 4692 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #27568 by @SerenityTn.
Dashboard cron page lists cron jobs from all profiles with profile-aware filter UI and storage routing. Includes test coverage for cross-profile listing, mutation, deletion, and validation.
Also fixes orphan conflict markers in
hermes_cli/config.pyleft in main by an earlier salvage merge (#28452 salvage of #23790). Thedispatch_stale_timeout_secondsconfig key was double-nested in stale HEAD/PR markers; this PR cleans them up and keeps both the worker_log_rotate_bytes/orchestrator block and the stale_timeout config (both belong on main).Resolved a small CronPage.tsx conflict — kept the contributor's
jobKey(cross-profile id namespacing) and main'sitems-startclassName. Authorship preserved via rebase merge.Validation