Skip to content

feat(kanban): wire dispatcher to dispatch review agents from review column (#23772)#28449

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-de55f5dd
May 19, 2026
Merged

feat(kanban): wire dispatcher to dispatch review agents from review column (#23772)#28449
teknium1 merged 1 commit into
mainfrom
hermes/hermes-de55f5dd

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvages #23772 by @thewillhuang.

Adds review as a valid kanban task status and extends dispatch_once to monitor the review column as a second dispatch source (after the existing ready column). Review agents get the sdlc-review skill auto-loaded.

  • Adds review to VALID_STATUSES (combined with main's scheduled state)
  • Adds claim_review_task() — atomically transitions review → running
  • Adds has_spawnable_review() — health telemetry mirror
  • Extends dispatch_once with a review column dispatch loop after the ready loop

Resolved 2 stale-base conflicts. Adapted claim_review_task signature to main's ttl_seconds: Optional[int] = None convention so it composes cleanly with main's _resolve_claim_ttl_seconds helper. Authorship preserved via rebase merge.

Validation

  • 14 review-related tests pass.

…olumn

Salvages #23772 by @thewillhuang. Adds 'review' as a valid kanban task
status and extends dispatch_once to monitor the review column as a
second dispatch source (in addition to the existing ready column).

- Adds 'review' to VALID_STATUSES
- Adds claim_review_task() — atomically transitions review → running
- Adds has_spawnable_review() — health telemetry mirror
- Extends dispatch_once with a review column dispatch loop
- Review agents get 'sdlc-review' skill auto-loaded

Resolved 2 conflicts (VALID_STATUSES merge with main's 'scheduled' state,
test file additions). Adapted claim_review_task to main's
ttl_seconds: Optional[int] = None convention (matches claim_task).
@teknium1 teknium1 merged commit f55d94a into main May 19, 2026
@teknium1 teknium1 deleted the hermes/hermes-de55f5dd branch May 19, 2026 04:19
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-de55f5dd vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8846 on HEAD, 8844 on base (🆕 +2)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4638 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins labels May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants