feat(kanban): stamp originating ACP session_id on tasks (#23208)#28447
Merged
Conversation
Salvages #23208 by @awizemann. Tracks which chat session created a kanban task so clients can render a per-session board without falling back to tenant + time-window heuristics. - Schema: tasks gains nullable session_id TEXT column with index (additive migration in _migrate_add_optional_columns). - ACP: server.py exposes the originating session id via HERMES_SESSION_ID with save/restore around the agent loop. - Tool: kanban_create reads HERMES_SESSION_ID (with explicit override). - CLI: 'hermes kanban list --session <id>' filter; JSON output exposes session_id.
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-attribute |
1 |
First entries
tests/tools/test_kanban_tools.py:835: [unresolved-attribute] unresolved-attribute: Attribute `session_id` is not defined on `None` in union `Task | None`
✅ Fixed issues: none
Unchanged: 4637 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #23208 by @awizemann.
Tracks which chat session created a kanban task so clients can render a per-session board without falling back to tenant + time-window heuristics.
tasksgains nullablesession_id TEXTcolumn with index. Additive migration in_migrate_add_optional_columns.acp_adapter/server.pyexposes originating session id viaHERMES_SESSION_IDwith proper save/restore around the agent loop.kanban_createreadsHERMES_SESSION_ID(explicitsession_idarg can override).hermes kanban list --session <id>filter; JSON output exposessession_id.Resolved 3 conflicts (acp_adapter previous_session_id alongside main's edit_approval_token, kanban_db migration block alongside main's model_override, create_task signature alongside main's initial_status). Authorship preserved via rebase merge.
Validation