fix: 4 small surgical bugs (#23302)#28423
Merged
Merged
Conversation
Salvages #23302 by @Bartok9. Four independent one-area fixes: 1. kanban boards delete alias now hard-deletes (not archives) — the alias didn't carry --delete, so getattr(args, 'delete', False) returned False. Detect boards_action=='delete' explicitly. 2. Gateway auto-title failures no longer leak as user-visible warnings — debug-log only since they're not actionable. 3. Background process completion notification snaps truncation to the next newline boundary, prepends a marker when content is dropped. 4. _cprint() schedules the run_in_terminal coroutine via asyncio.ensure_future so output isn't silently dropped from background threads (fixes #23185 Bug A). Skips the double-print fallback that would fire for mock paths.
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-assignment |
1 |
invalid-argument-type |
1 |
First entries
gateway/run.py:16192: [invalid-assignment] invalid-assignment: Invalid subscript assignment with key of type `Literal["title_callback"]` and value of type `(title: str) -> None` on object of type `dict[str, ((task: str, exc: BaseException) -> None) | dict[str, Any | None] | None]`
gateway/run.py:16203: [invalid-argument-type] invalid-argument-type: Argument to function `maybe_auto_title` is incorrect: Expected `((str, /) -> None) | None`, found `((task: str, exc: BaseException) -> None) | dict[str, Any | None] | None`
✅ Fixed issues (1):
| Rule | Count |
|---|---|
invalid-argument-type |
1 |
First entries
gateway/run.py:16188: [invalid-argument-type] invalid-argument-type: Argument to function `maybe_auto_title` is incorrect: Expected `((str, /) -> None) | None`, found `Any | None | dict[str, Any | None]`
Unchanged: 4625 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #23302 by @Bartok9.
Four independent one-area fixes from the original PR:
hermes kanban boards delete <slug>now hard-deletes (it was archiving instead because--deletebelongs to thermsubparser only). Detectboards_action=='delete'explicitly.⚠messages. Debug-log only — not actionable to the end user.[… output truncated — showing last N chars]._cprint()cross-thread coroutine fix: schedulerun_in_terminalviaasyncio.ensure_futureso output isn't silently GC'd from background threads. Removes the double-print fallback path for mocked builds.Original branch was stale; applied each substantive change manually onto current main. Authorship preserved via rebase merge.