Skip to content

fix(kanban): reject direct running transitions in dashboard bulk updates (#24050)#28411

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-de55f5dd
May 19, 2026
Merged

fix(kanban): reject direct running transitions in dashboard bulk updates (#24050)#28411
teknium1 merged 1 commit into
mainfrom
hermes/hermes-de55f5dd

Conversation

@teknium1

@teknium1 teknium1 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Salvages #24050 by @kronexoi.

Single-task PATCH already rejects status='running' (bypasses dispatcher/claim invariant), but bulk-update endpoint still accepted it. Aligns bulk with single by emitting an error result for any 'running' entry.

Original branch was stale; applied the substantive fix manually onto current main. Authorship preserved via rebase merge.

Validation

  • New test (test_bulk_status_running_rejected) passes.

@kronexoi @teknium1
fix(kanban): reject direct running transitions in dashboard bulk updates
cd8bc9a 
Salvages #24050 by @kronexoi. The single-task PATCH already rejects
direct status='running' since it bypasses the dispatcher/claim invariant,
but the bulk-update endpoint still accepted it. Aligns bulk with single
by emitting an error result row for any 'running' entry.
@teknium1 teknium1 merged commit e8ce7b8 into main May 19, 2026
@teknium1 teknium1 deleted the hermes/hermes-de55f5dd branch May 19, 2026 03:38
@teknium1 teknium1 mentioned this pull request May 19, 2026
Closed
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins labels May 19, 2026
@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-de55f5dd vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8814 on HEAD, 8814 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4626 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@teknium1 @alt-glitch @kronexoi