Skip to content

fix(packaging): ship dashboard plugin assets in wheel (#23737)#28406

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-de55f5dd
May 19, 2026
Merged

fix(packaging): ship dashboard plugin assets in wheel (#23737)#28406
teknium1 merged 1 commit into
mainfrom
hermes/hermes-de55f5dd

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvages #23737 by @LeonSGP43.

Adds plugins/* manifest.json and dist/ globs to setuptools package-data so wheel installs ship the bundled dashboard plugin assets. Without these, /api/dashboard/plugins can't discover plugin assets outside a source checkout.

Original branch was stale; applied the substantive change manually onto current main. Authorship preserved via rebase merge.

Validation

  • New regression test (test_dashboard_plugin_manifests_and_assets_are_packaged) passes.

Salvages #23737 by @LeonSGP43. Adds plugins/* manifest.json and dist/
glob entries to setuptools package-data so wheel installs ship the
bundled dashboard plugin assets (kanban, achievements, etc.). Without
these, /api/dashboard/plugins can't discover plugin assets outside a
source checkout.
@teknium1 teknium1 requested a review from a team May 19, 2026 03:34
@teknium1 teknium1 merged commit fdb374e into main May 19, 2026
4 checks passed
@teknium1 teknium1 deleted the hermes/hermes-de55f5dd branch May 19, 2026 03:35
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins labels May 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-de55f5dd vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8813 on HEAD, 8813 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4625 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants