fix(kanban): don't crash workers when kanban-worker skill is absent (#27372)#28405
Merged
Conversation
…is absent Salvages #27372 by @oemtalks. The dispatcher unconditionally injected `--skills kanban-worker` into every worker spawn, but worker profiles sometimes don't have that bundled skill in their skills dir, which is fatal at CLI startup (`ValueError: Unknown skill(s): kanban-worker`). Adds `_kanban_worker_skill_available(hermes_home)` and only injects the flag when the skill resolves. The MANDATORY lifecycle still ships via KANBAN_GUIDANCE in the system prompt, so omitting the flag is safe.
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvages #27372 by @oemtalks.
Dispatcher unconditionally injected
--skills kanban-workerinto every worker spawn, but worker profiles sometimes don't have that bundled skill — fatal at CLI startup (ValueError: Unknown skill(s): kanban-worker). Adds_kanban_worker_skill_available(hermes_home)helper and gates the flag on actual resolvability. KANBAN_GUIDANCE still ships the MANDATORY lifecycle via system prompt, so omitting the optional pattern library is safe.Original branch was severely stale; applied the substantive change manually onto current main. Authorship preserved via rebase merge.