fix(cli): preserve cron asterisks in strip mode (#28019)#28353
Merged
Conversation
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #28019 by @felix-windsor.
What:
_strip_markdown_syntax()treated any line of 3+ asterisks as a Markdown horizontal rule and stripped it. Cron expressions like* * * * *(5 asterisks separated by spaces) matched the HR pattern and were silently removed from agent output. The single-emphasis stripper*text*also chewed up bare asterisks.How:
-and_still strip on 3+, but*only strips on exactly 3 (the canonical CommonMark form* * *).*emphasis*regex to require non-whitespace at both inner edges, so* * * * *no longer matches as five emphasis groups.* * *HR still stripped.Original PR: #28019
Fixes #28010.