fix(send_message): resolve Slack user IDs to DM channel IDs (#27936)#28349
Merged
Conversation
The _SLACK_TARGET_RE regex only matched IDs starting with C (channel), G (group), or D (direct message). Slack user IDs start with U, causing 'Could not resolve' errors when trying to send DMs to specific users. Changes: - Expand _SLACK_TARGET_RE to accept U-prefixed IDs (user IDs) - Add conversations.open fallback to resolve user IDs to DM channel IDs before sending, since chat.postMessage requires a conversation ID Fixes #ISSUE_NUMBER
4 tasks
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #27936 by @jvinals.
What:
_SLACK_TARGET_REaccepted onlyC/G/D-prefixed Slack IDs (channels, groups, DMs). When the agent had a Slack user ID (U-prefixed, e.g. from message metadata),send_messagefell through to channel-name resolution and failed — Slack's chat.postMessage requires a conversation ID, not a user ID.How:
Uto the regex so user IDs are recognized as Slack targets.U-prefixed targets, callconversations.opento fetch the DM channel ID (D...) and swapchat_idto that before posting.im:writescope is missing.Original PR: #27936