fix(agent): add qwen and deepseek to TOOL_USE_ENFORCEMENT_MODELS (#28195)#28348
Merged
Conversation
Qwen3.x and DeepSeek-V3.x default to chatty/hallucinatory tool use without enforcement steering — agents narrate "calling tool X" without actually emitting a tool call, or run partial loops. Both model families fit the same failure pattern TOOL_USE_ENFORCEMENT_GUIDANCE was already injected for (gpt, codex, gemini, gemma, grok, glm). Co-authored-by: briandevans <252620095+briandevans@users.noreply.github.com> Squashed salvage of: - 403e567 fix(agent): add qwen and deepseek to TOOL_USE_ENFORCEMENT_MODELS - 9433eab test(agent): use realistic qwen-plus identifier in enforcement test Fixes #28079.
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #28195 by @briandevans (squashed 2-commit stack: fix + test improvement). Supersedes already-closed #28081.
What: Qwen3.x and DeepSeek-V3.x default to chatty/hallucinatory tool use without enforcement steering — agents narrate "calling tool X" without actually emitting a tool call, or run partial loops.
How: Add
qwenanddeepseeksubstrings toTOOL_USE_ENFORCEMENT_MODELSinagent/prompt_builder.py. Two new unit tests intest_prompt_builder.pyand two integration tests intest_run_agent.pyverify auto-mode injection for each model family.Original PR: #28195
Fixes #28079.