fix: import _pool_may_recover_from_rate_limit via _ra() in conversation_loop.py#28254
Closed
Poeagle wants to merge 1 commit into
Closed
fix: import _pool_may_recover_from_rate_limit via _ra() in conversation_loop.py#28254Poeagle wants to merge 1 commit into
Poeagle wants to merge 1 commit into
Conversation
…on_loop.py The run_conversation function was extracted from run_agent.py to the new agent/conversation_loop.py (0530252). During extraction, the call to _pool_may_recover_from_rate_limit() was left as a bare name but the function wasn't imported in the new file. All other run_agent-level symbols (handle_function_call, _set_interrupt, OpenAI) are accessed via the _ra() lazy-import helper in this file, so this is consistent with the existing pattern. Fixes NameError: name '_pool_may_recover_from_rate_limit' is not defined
Collaborator
Contributor
|
Closing as duplicate of #28159 by @AceWattGit, which has been merged via salvage PR #28345 (commit 25e0f4d). All three of your PRs converged on the same fix (routing the call through `_ra()`), and AceWattGit's version also ships an inspect-based regression test guarding the call shape. Thanks for spotting the NameError — community signal helped triage it fast. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
run_conversationfunction was extracted fromrun_agent.pyto the newagent/conversation_loop.py(commit 0530252). During extraction, the call to_pool_may_recover_from_rate_limit()was left as a bare name but the function wasn't imported in the new file.All other
run_agent-level symbols (handle_function_call,_set_interrupt,OpenAI) are accessed via the_ra()lazy-import helper in this file, so this change is consistent with the existing pattern.Fixes
NameError: name '_pool_may_recover_from_rate_limit' is not definedat runtime.