feat: show names of user-modified skills in bundled skill sync summary#28206
Closed
zccyman wants to merge 1 commit into
Closed
feat: show names of user-modified skills in bundled skill sync summary#28206zccyman wants to merge 1 commit into
zccyman wants to merge 1 commit into
Conversation
When 'hermes update' syncs bundled skills, the summary line only shows the count of user-modified skills that were kept (e.g. '3 user-modified (kept)'), but not *which* skills. Once the update finishes, the user has no way to know which skills need triage. Append the skill names to the summary line, truncated to 5 with a '+N more' suffix for long lists: Done: 12 new, 3 updated, 7 unchanged, 3 user-modified (kept): hermes-agent, debugging-hermes-tui-commands, system-health. 25 total bundled. Closes NousResearch#28121
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
hermes updatesyncs bundled skills, the summary line only shows the count of user-modified skills that were kept (e.g.3 user-modified (kept)), but not which skills. Once the update finishes, the user has no way to know which skills need triage.Closes #28121
Fix
Append the skill names to the summary line, truncated to 5 with a
+N moresuffix for long lists:Files Changed
tools/skills_sync.py— +6/-1 lines: append names list to user-modified summaryTesting
tests/tools/test_skills_sync.py