fix: include hermes_plugins in gateway.log component filter#28196
Closed
zccyman wants to merge 1 commit into
Closed
fix: include hermes_plugins in gateway.log component filter#28196zccyman wants to merge 1 commit into
zccyman wants to merge 1 commit into
Conversation
gateway.log uses a _ComponentFilter that only passes records from
loggers starting with ('gateway',). Plugin modules are loaded under
the hermes_plugins.* namespace, so all plugin log output is silently
dropped from gateway.log.
This makes plugin registration — which directly affects gateway hooks
(pre_gateway_dispatch, transform_llm_output, etc.) — invisible in
the gateway-specific log. Operators debugging gateway behavior check
gateway.log and see no plugin activity, even when plugins are working
correctly.
Add 'hermes_plugins' to the gateway component prefixes tuple so
plugin log messages appear in gateway.log.
Closes NousResearch#28138
outsourc-e
approved these changes
May 18, 2026
outsourc-e
left a comment
Contributor
There was a problem hiding this comment.
Reviewed locally. Tiny logging-prefix fix, py_compile passed, and a direct _ComponentFilter smoke check confirms gateway filtering now includes hermes_plugins.* while still excluding agent.*. Good merge candidate.
3 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gateway.loguses a_ComponentFilterthat only passes records from loggers starting with("gateway",). Plugin modules are loaded under thehermes_plugins.*namespace, so all plugin log output is silently dropped fromgateway.log.This makes plugin registration — which directly affects gateway hooks (
pre_gateway_dispatch,transform_llm_output, etc.) — invisible in the gateway-specific log. Operators debugging gateway behavior checkgateway.logand see no plugin activity, even when plugins are working correctly.Closes #28138
Fix
Add
"hermes_plugins"to the gatewayCOMPONENT_PREFIXEStuple inhermes_logging.py.Files Changed
hermes_logging.py— 1 line:("gateway",)→("gateway", "hermes_plugins")Testing