fix: elevate plugin discovery failures from debug to warning#28193
Closed
zccyman wants to merge 1 commit into
Closed
fix: elevate plugin discovery failures from debug to warning#28193zccyman wants to merge 1 commit into
zccyman wants to merge 1 commit into
Conversation
Plugin discovery exceptions in gateway startup (gateway/run.py) and CLI startup (hermes_cli/main.py) are caught and logged at DEBUG level, making them invisible at the default INFO log level. If any plugin import fails — syntax error, missing dependency, import cycle — operators get zero indication unless they bump the log level to DEBUG. This makes broken plugins appear enabled but silently non-functional. Change both locations to logger.warning() so failures are visible at production log levels. Closes NousResearch#28137
outsourc-e
approved these changes
May 18, 2026
outsourc-e
left a comment
Contributor
There was a problem hiding this comment.
Reviewed locally in a clean worktree. This is the right severity change: plugin discovery failures at startup are operationally important and should be visible at default log levels. I did not find any behavioral or security regression in the touched path.
3 tasks
This was referenced May 19, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Plugin discovery exceptions in gateway startup (
gateway/run.py) and CLI startup (hermes_cli/main.py) are caught and logged atDEBUGlevel, making them invisible at the defaultINFOlog level. If any plugin import fails — syntax error, missing dependency, import cycle — operators get zero indication unless they bump the log level toDEBUG.This means broken plugins appear enabled in config but silently do nothing. Diagnosing requires either
HERMES_PLUGINS_DEBUG=1(undocumented for most users) or editing config to raise log level.Closes #28137
Fix
Change
logger.debug(...)→logger.warning(...)in both locations so plugin discovery failures are visible at production log levels.Files Changed
gateway/run.py—logger.debug→logger.warning(1 line)hermes_cli/main.py—logger.debug→logger.warning(1 line)Testing