fix(mattermost): use thread root_id from metadata for CRT thread replies#28192
Closed
outsourc-e wants to merge 2 commits into
Closed
fix(mattermost): use thread root_id from metadata for CRT thread replies#28192outsourc-e wants to merge 2 commits into
outsourc-e wants to merge 2 commits into
Conversation
When reply_mode=thread and a user sends from inside a CRT Thread, the previous code used reply_to (user's message ID) as root_id. In Mattermost CRT, root_id must point to the root-level post, not a nested reply. Using the wrong ID causes 400 Invalid RootId. Fix: use metadata['thread_id'] (set by _thread_metadata_for_source) which correctly contains the Thread's root message ID. Closes NousResearch#28005
Collaborator
5 tasks
Contributor
|
Closing as duplicate of #28251 by @colin-chang, which was merged via salvage PR #28354 (commit 06161c6). Both PRs fix the same Mattermost CRT root_id bug — your approach used the thread_id from metadata as a fallback; colin-chang's used an API roundtrip via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The upstream PR #28012 is conceptually right but stacked with an unrelated gateway restart notification config fix. This branch keeps only the Mattermost CRT fix.
Test Plan
Closes #28005
Supersedes #28012