fix(plugins): include platforms/ namespace in bundled platform plugin keys#28179
Open
outsourc-e wants to merge 1 commit into
Open
fix(plugins): include platforms/ namespace in bundled platform plugin keys#28179outsourc-e wants to merge 1 commit into
outsourc-e wants to merge 1 commit into
Conversation
… keys Bundled gateway platform plugins under plugins/platforms/<name>/ were discovered with keys derived from the manifest name (e.g. teams-platform) instead of the path-derived namespaced key (e.g. platforms/teams). This broke config entries in plugins.enabled / plugins.disabled that use canonical namespaced keys, because the discovery key did not match. Pass prefix='platforms' to _scan_directory_level() when scanning the platforms directory so keys are computed as platforms/<dir_name>. Closes NousResearch#27548
9 tasks
BoardJames-Bot
approved these changes
May 18, 2026
BoardJames-Bot
left a comment
There was a problem hiding this comment.
Reviewed by Hermes. Platform plugin scan now preserves the platforms/ namespace while leaving flat bundled plugin keys alone; focused plugin suite passed locally (73 passed in tests/hermes_cli/test_plugins.py). No blockers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean replacement for #28160.\n\nWhy:\n- #28160 is non-mergeable/conflicting against current main\n- this branch reapplies the same fix cleanly on top of current upstream/main\n\nWhat it does:\n- scans bundled plugins/platforms/* with prefix='platforms'\n- makes bundled platform plugin keys match canonical namespaced config keys like platforms/teams\n- keeps existing bundled plugin logging intact\n\nVerification:\n- scripts/run_tests.sh tests/hermes_cli/test_plugins.py\n- 73 passed\n\nIssue:\n- closes #27548