fix(gateway): write update notification to session transcript (#27846)#27884
fix(gateway): write update notification to session transcript (#27846)#27884zccyman wants to merge 1 commit into
Conversation
zccyman
commented
May 18, 2026
- feat(gateway): add contextual rationale to approval prompts
- fix(gateway): write update notification to session transcript
|
Board James checked the branch-local Windows/ruff blocker and confirmed the minimal fix is just adding the explicit config read encoding in - with open(_cfg_path) as _f:
+ with open(_cfg_path, encoding="utf-8") as _f:Local validation on the PR head plus the fix:
I couldn't push directly to |
When the gateway restarts after 'hermes update', _send_update_notification sends a standalone adapter.send() that lands outside the conversation history. The agent then cannot see that an update already occurred, causing it to repeat upgrade prompts and lose context of the update outcome. The fix writes the notification as a system message into the session transcript before sending, so the agent retains full context of the update outcome. Fixes NousResearch#27846.
1ed58f9 to
61478a3
Compare
|
This PR substantially duplicates #27833 (contextual rationale for approval prompts) — 9 of 14 files are identical. Additionally, it includes committed junk files ( The unique parts (update notification transcript fix for #27846 and |
|
Closing in favor of #27906 (clean rebuild containing only the #27846 update notification fix) and #27833 (contextual rationale for approval prompts). Per alt-glitch's review, this PR was correctly flagged as duplicating #27833 — 7 of 10 files overlapped with the contextual rationale feature. The unique #27846 portion (update notification → session transcript) has been extracted into a clean branch from Apologies for the branch management blunder — the two unrelated fixes should never have been on the same branch. |