Skip to content

feat(kanban): make worker log retention configurable#27867

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-6df71afb
May 18, 2026
Merged

feat(kanban): make worker log retention configurable#27867
teknium1 merged 1 commit into
mainfrom
hermes/hermes-6df71afb

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Salvage of #25639 from @qWaitCrypto onto current main.

Adds two config knobs for kanban worker log rotation:

  • kanban.worker_log_rotate_bytes (default 2 MiB — historical)
  • kanban.worker_log_backup_count (default 1 — historical)

Defaults preserve the existing single-generation rotation behavior. Long-running workers can raise either value to keep more early failure evidence.

  • Multi-generation rotation shifts .log.1 → .log.2 → ... up to backup_count.
  • backup_count=0 unlinks the active log instead of rotating (advanced opt-out).

Original PR: #25639.

Validation

  • 3 new targeted tests passing; existing rotation tests still green (9/9 in the touched test selection).

@teknium1 teknium1 merged commit 6e60a8a into main May 18, 2026
16 of 17 checks passed
@teknium1 teknium1 deleted the hermes/hermes-6df71afb branch May 18, 2026 08:21
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-6df71afb vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 8779 on HEAD, 8779 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4616 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@alt-glitch alt-glitch added type/feature New feature or request comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles P3 Low — cosmetic, nice to have labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants