fix(docker): preload messaging gateway deps via --extra messaging (salvage #26394)#27558
Merged
Conversation
Contributor
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #26394 — published Docker image's
uv synconly installs the[all]extra, leaving messaging adapter deps (python-telegram-bot, discord.py, slack-bolt, etc.) to be lazy-installed at first gateway boot. That works only if the.venvis writable AND first-boot lazy install succeeds. Faster, more reliable to bake the deps in.Changes
Dockerfile— extend theuv syncline to--extra all --extra messaging. Adjust the trailing comment about lazy_deps to clarify it now handles only optional/future deps, not the messaging baseline.tests/tools/test_dockerfile_pid1_reaping.py— regression test asserting--extra messagingappears in the no-install-project sync step.Validation
scripts/run_tests.sh tests/tools/test_dockerfile_pid1_reaping.py -q→ 7/7 pass.[messaging]extra confirmed present inpyproject.toml.Original PR: #26394 — credit preserved via rebase-merge.