fix(codex): scope kanban worker writable root in app-server sandbox (salvage #26212)#27557
Merged
Conversation
Contributor
🔎 Lint report:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #26212 — codex-runtime Kanban workers (spawned via
codex app-serverwithHERMES_KANBAN_TASKset) need to write board state (handoff/status/SQLite) to a path outside their per-task workspace. Without an explicit writable-root override, they finish the actual work and then crash/block when the kanban_complete / kanban_block tools try to write the board DB.Fix keeps the Codex sandbox on (does NOT fall back to
danger-full-access); just adds the Kanban root as the single extra writable root and disables network there.Changes
agent/transports/codex_app_server.py— whenHERMES_KANBAN_TASKis set, derive the kanban root fromHERMES_KANBAN_DB's parent (fallback:HERMES_KANBAN_ROOTor$HERMES_HOME/kanban) and pass three-coverrides:sandbox_mode="workspace-write",sandbox_workspace_write.writable_roots=[<kanban_root>],sandbox_workspace_write.network_access=false.tests/agent/transports/test_codex_app_server_runtime.py— regression test asserts (a) the kanban root is added, (b) network access is disabled, (c) nodanger-*mode is used.website/docs/user-guide/features/codex-app-server-runtime.md— minor docs touch.Validation
scripts/run_tests.sh tests/agent/transports/test_codex_app_server_runtime.py -q→ 27/27 pass.Original PR: #26212 — credit preserved via rebase-merge.