fix: use _ra() accessor for _pool_may_recover_from_rate_limit#27532
Closed
bynguts wants to merge 1 commit into
Closed
fix: use _ra() accessor for _pool_may_recover_from_rate_limit#27532bynguts wants to merge 1 commit into
bynguts wants to merge 1 commit into
Conversation
The function is defined in run_agent.py but was being called directly in conversation_loop.py, causing NameError: name '_pool_may_recover_from_rate_limit' is not defined. Changed to _ra()._pool_may_recover_from_rate_limit to match the pattern used for other run_agent functions.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Routes the _pool_may_recover_from_rate_limit call through the lazy _ra() accessor so test/runtime patches applied to the run_agent module are honored at this call site.
Changes:
- Replace direct reference to
_pool_may_recover_from_rate_limitwith_ra()._pool_may_recover_from_rate_limit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix NameError when rate limit recovery triggers.
In
agent/conversation_loop.pyline 2254,_pool_may_recover_from_rate_limitwas called directly but defined inrun_agent.py. Changed to_ra()._pool_may_recover_from_rate_limit()to match the pattern used for other run_agent functions:Fixes NameError: name "_pool_may_recover_from_rate_limit" is not defined