fix: harden execute_code env and approvals#27304
Closed
YLChen-007 wants to merge 1 commit into
Closed
Conversation
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
I rechecked this against current |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27303
Summary
execute_codechild environment scrubbing with an explicit safe allowlistHERMES_*variables into sandboxed child processes by defaultDATABASE_URL,SLACK_WEBHOOK,AWS_ACCESS_ID, andSENTRY_DSNterminal()calls requested from inside the execute-code sandboxTests
/root/project/xclaw-project/hermes-agent/.venv/bin/python -m pytest -o addopts= --ignore=tests/integration --ignore=tests/e2e -m 'not integration' tests/tools/test_env_passthrough.py tests/tools/test_code_execution.py::TestExecuteCode::test_terminal_tool_call_runs_approval_guard -q(20 passed)Note: the broader
tests/tools/test_code_execution.pyfile currently has two unrelated failures in this environment becausepsutilis not importable from the shared venv when timeout/interrupt tests call_kill_process_group.